Fix artifact citation path sandbox bypass#4
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: g00sifer Development Lab <g00siferdev-py@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Artifact citations were accepted from model-provided artifact JSON and passed to
open_pathwithout a workspace containment check. A malicious or prompt-injected artifact could cite an absolute path or..traversal, and a user clicking the citation would open files outside the Persistent Sage workspace. Project tools were also exposed whenever artifacts were enabled, bypassing the explicit workspace-tools opt-in for workspace writes.Root cause
open_pathallowed absolute paths and raw workspace joins, artifact validation did not inspect citation paths, and chat tool registration usedartifacts_enabledto provide project tools/workspace roots.Fix
open_paththrough the same workspace path jail used by agent tools, including symlink containment checks.Validation
cargo +stable test(37 Rust tests passed)npm run build