Fix stale chat reloads overwriting selected thread#5
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: g00sifer Development Lab <g00siferdev-py@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
A completed send in conversation A could reload A after the user had already switched to conversation B. Because
loadActiveThreadonly checked a global sequence number and not the active conversation, A's reload could invalidate B's in-flight load and render the wrong transcript under B's selected thread. This could look like lost chat history and lead users to reply in the wrong context.Root cause
loadActiveThreadincrementedloadSeqand applied messages/briefing/anchors without verifying that the loaded conversation still matchedactiveConversationIdRef.current. Itsfinallyalso always clearedthreadLoading, even when a newer thread load owned the loading state.Fix
threadLoadingso stale loads cannot clear a newer load's spinner.Validation
npm test -- src/hooks/useChat.test.tsx(passes; jsdom prints a canvas getContext warning from imported chart code)npm test(passes; same jsdom canvas warning)npm run build(passes; existing large chunk warning)