Fix workspace citation path containment#7
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: g00sifer Development Lab <g00siferdev-py@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Assistant artifacts can include model-controlled citation buttons. Those paths were passed to
open_path, which accepted absolute paths and workspace-relative traversal such asworkspace/../.... A prompt-injected or malicious artifact could label a citation deceptively and cause the OS to open a file outside the Persistent Sage workspace when clicked.Root cause
open_pathjoined relative input directly to the workspace root, allowed absolute paths unchanged, and did not reuse the workspace path sanitizer / containment check used by agent file tools.Fix
Resolve
open_pathinputs through the workspace subpath sanitizer, reject absolute paths and..traversal, assert canonical containment in the workspace, and only then open existing paths. Added unit tests for a validworkspace/projectspath plus traversal and absolute-path rejection.Validation
cargo +stable test --manifest-path src-tauri/Cargo.toml open_path_ -- --nocapturecargo +stable test --manifest-path src-tauri/Cargo.toml