Fix Store updater status and stale chat reload races#8
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: g00sifer Development Lab <g00siferdev-py@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Root cause
install_store_updatesignoredStorePackageUpdateResult.OverallStateand always returnedrestartRequired: trueonce the Store async operation completed.loadActiveThreadonly guarded async responses with a sequence id; post-send/recipe reloads did not verify the source conversation was still active.Fix
StorePackageUpdateState::Completedas a successful Store install, return non-restarting success forCanceled, and surface all other states as errors.Validation
npm ci && npm run buildcargo check --manifest-path src-tauri/Cargo.tomlcargo check --manifest-path src-tauri/Cargo.toml --target x86_64-pc-windows-gnu