Bump okhttp to 5.1.0 #440
Merged
Bump okhttp to 5.1.0 #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job Summary for GradleCheck PR :: kotlin-tests
|
Job Summary for GradleCheck PR :: kotlin-tests
|
In current order, Kotlin kernel still picks the older okio for the classpath. https://scans.gradle.com/s/zxnnjlueycuxg/tests/task/:library:examplesTest/details/com.gabrielfeo.develocity.api.example.notebook.NotebooksTest/testMostFrequentBuildsNotebook()?focused-execution=1&page=eyJvdXRwdXQiOnsiMCI6NH19&top-execution=1#L749
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump okhttp to 5.1.0 and re-order dependency declarations so that the Kotlin kernel for Jupyter will use the higher version of
okio,3.15.0, which is requested and required byokhttp:5.1.0, avoiding a runtime failure.The change in the buildscript is reflected in the library's published
.pomfile. It appears that the kernel will pick the first seen version of an artifact when traversing the dependencies and does not consider dependency constraints.okhttpmust be declared first in the pom file andmoshi, which depends on an older version ofokio, must be declared later.This bump without re-ordering dependencies would result in a failure as described in Kotlin/kotlin-jupyter#484 and seen in this build scan from #425.