Skip to content

avoid hardcoded magic number #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

avoid hardcoded magic number #11

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a8917e
avoid hardcoded magic number
itrs Jun 1, 2015
d20f2e5
disable extentions by default
itrs Jun 1, 2015
705c090
default to windowSize 1
itrs Jun 1, 2015
ef8708f
fix typo
itrs Jun 1, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions lib/create-options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ module.exports = function (opts, server){
}

//Default window size 4: https://github.com/joyent/node/issues/6696
var windowSize = sanitizeNumber (opts.windowSize || 4);
if (windowSize > 65535) windowSize = 4;
var windowSize = sanitizeNumber (opts.windowSize || 1);
if (windowSize > 65535) windowSize = 1;

//Maximum block size before IP packet fragmentation on Ethernet networks
var blockSize = sanitizeNumber (opts.blockSize || 1468);
Expand All @@ -40,17 +40,20 @@ module.exports = function (opts, server){
rollover: 0
};


// disable these extension by default
options.extensionsString = {
blksize: blockSize + "",
timeout: timeout + "",
windowsize: windowSize + "",
rollover: "0"
// blksize: blockSize + "",
// timeout: timeout + "",
// windowsize: windowSize + "",
// rollover: "0"
};

options.extensionsLength = 48 +
options.extensionsString.blksize.length +
options.extensionsString.timeout.length +
options.extensionsString.windowsize.length;

options.extensionsLength = "tsize".length + 2;
for (var k in options.extensionsString) {
options.extensionsLength += (k.length + extensionsString[k].length + 2);
};


return options;
};