Skip to content

PBR add multi scattering as energy compensation #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

PBR add multi scattering as energy compensation #1370

wants to merge 5 commits into from

Conversation

@zhuxudong
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
    furnace test:
    image
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

feature，conservation of energy

image

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No.

Other information:

@zhuxudong zhuxudong added the enhancement New feature or request label Feb 10, 2023
@zhuxudong zhuxudong added this to the 1.0 milestone Feb 10, 2023
@zhuxudong zhuxudong self-assigned this Feb 10, 2023
@zhuxudong zhuxudong linked an issue Feb 14, 2023 that may be closed by this pull request
Add energy compensation #935
Open
@GuoLei1990 GuoLei1990 modified the milestones: 1.0, 1.1 May 18, 2023
@GuoLei1990 GuoLei1990 changed the base branch from dev/1.0 to dev/1.1 June 5, 2023 14:39
@GuoLei1990 GuoLei1990 changed the base branch from dev/1.1 to main September 15, 2023 09:33
@GuoLei1990 GuoLei1990 modified the milestones: 1.1, 1.2 Oct 7, 2023
@GuoLei1990 GuoLei1990 added medium priority Medium priority issue material low priority Low priority issue and removed medium priority Medium priority issue labels Oct 7, 2023
@zhuxudong zhuxudong removed this from the 1.2 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuoLei1990 GuoLei1990 Awaiting requested review from GuoLei1990

@yangfengzzz yangfengzzz Awaiting requested review from yangfengzzz

At least 2 approving reviews are required to merge this pull request.

Assignees

@zhuxudong zhuxudong

Labels

enhancement New feature or request low priority Low priority issue material

Projects

PBR material
Status: In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add energy compensation

3 participants

@zhuxudong @GuoLei1990 @yangfengzzz