FontLoader should use cache

[cptbtptpbcptdtptp]

Please check if the PR fulfills these requirements

• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Summary by CodeRabbit

• New Features

  • None.

• Bug Fixes

  • None.

• Refactor

  • Simplified font loading configuration to align with default behavior.

• Chores

  • Internal annotation updated for font loading; no user-facing changes expected.

[coderabbitai]

Walkthrough

Removed the third boolean parameter from the FontLoader class decorator, changing @resourceLoader(AssetType.Font, ["font"], false) to @resourceLoader(AssetType.Font, ["font"]). No other code was modified.

Changes

Cohort / File(s)	Summary
Loader decorator parameter update packages/loader/src/FontLoader.ts	Removed the explicit false argument from the resourceLoader decorator on FontLoader, leaving two parameters: AssetType.Font and ["font"].

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I nibbled a flag from the loader’s vine,
A tiny nib—now two args align.
Fonts still hop in, neat and spry,
Less chatter, same sky-high supply.
Thump-thump! My paws approve the trim—
Clean trails make swift rabbits grin. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title clearly states that FontLoader will now use the cache, accurately capturing the primary change of removing the explicit false argument in the decorator to enable caching.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 67e68ca and 959add1.

📒 Files selected for processing (1)

• packages/loader/src/FontLoader.ts (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

packages/loader/src/FontLoader.ts (1)

packages/core/src/asset/ResourceManager.ts (1)

• resourceLoader (627-632)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: e2e (22.x, 2/4)
• GitHub Check: e2e (22.x, 4/4)
• GitHub Check: build (22.x, windows-latest)
• GitHub Check: codecov

🔇 Additional comments (1)

packages/loader/src/FontLoader.ts (1)

11-11: Caching enabled via default decorator parameter looks good.

Letting the decorator fall back to its default useCache = true is the right way to opt into caching, so this aligns FontLoader with the rest of the loaders without any further changes needed.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.78%. Comparing base (67e68ca) to head (959add1).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2851      +/-   ##
==========================================
- Coverage   79.78%   79.78%   -0.01%     
==========================================
  Files         857      857              
  Lines       93396    93396              
  Branches     9373     9376       +3     
==========================================
- Hits        74519    74515       -4     
- Misses      18726    18730       +4     
  Partials      151      151              

Flag	Coverage Δ
unittests	79.78% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.