-
Notifications
You must be signed in to change notification settings - Fork 84
Update MAGs workflow to 0.4 #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from my one comment this is looking good.
Would be nice if you could also provide readme and help in the workflow.
"output_name": "output" | ||
} | ||
}, | ||
"inputs": [], | ||
"label": null, | ||
"name": "Extract element identifiers", | ||
"outputs": [ | ||
{ | ||
"name": "output", | ||
"type": "txt" | ||
} | ||
], | ||
"position": { | ||
"left": 318.90618896484375, | ||
"top": 9.914764404296875 | ||
}, | ||
"post_job_actions": { | ||
"ChangeDatatypeActionoutput": { | ||
"action_arguments": { | ||
"newtype": "tabular" | ||
}, | ||
"action_type": "ChangeDatatypeAction", | ||
"output_name": "output" | ||
} | ||
}, | ||
"tool_id": "toolshed.g2.bx.psu.edu/repos/iuc/collection_element_identifiers/collection_element_identifiers/0.0.2", | ||
"tool_shed_repository": { | ||
"changeset_revision": "d3c07d270a50", | ||
"name": "collection_element_identifiers", | ||
"owner": "iuc", | ||
"tool_shed": "toolshed.g2.bx.psu.edu" | ||
}, | ||
"tool_state": "{\"input_collection\": {\"__class__\": \"ConnectedValue\"}, \"__page__\": 0, \"__rerun_remap_job_id__\": null}", | ||
"tool_version": "0.0.2", | ||
"type": "tool", | ||
"uuid": "e0c0bcc7-4b35-4e5f-a661-ddea0ad484bc", | ||
"when": null, | ||
"workflow_outputs": [] | ||
}, | ||
"2": { | ||
"annotation": "", | ||
"content_id": "Paste1", | ||
"errors": null, | ||
"id": 2, | ||
"input_connections": { | ||
"input1": { | ||
"id": 1, | ||
"output_name": "output" | ||
}, | ||
"input2": { | ||
"id": 1, | ||
"output_name": "output" | ||
} | ||
}, | ||
"inputs": [], | ||
"label": null, | ||
"name": "Paste", | ||
"outputs": [ | ||
{ | ||
"name": "out_file1", | ||
"type": "input" | ||
} | ||
], | ||
"position": { | ||
"left": 643.4659118652344, | ||
"top": 8.522735595703125 | ||
}, | ||
"post_job_actions": { | ||
"ChangeDatatypeActionout_file1": { | ||
"action_arguments": { | ||
"newtype": "tabular" | ||
}, | ||
"action_type": "ChangeDatatypeAction", | ||
"output_name": "out_file1" | ||
} | ||
}, | ||
"tool_id": "Paste1", | ||
"tool_state": "{\"delimiter\": \"T\", \"input1\": {\"__class__\": \"ConnectedValue\"}, \"input2\": {\"__class__\": \"ConnectedValue\"}, \"__page__\": 0, \"__rerun_remap_job_id__\": null}", | ||
"tool_version": "1.0.0", | ||
"type": "tool", | ||
"uuid": "4619bff8-86aa-41a9-aa0b-5def4f7bad00", | ||
"when": null, | ||
"workflow_outputs": [ | ||
{ | ||
"label": "out_file1", | ||
"output_name": "out_file1", | ||
"uuid": "a608b960-25af-4a9e-a4a9-5b12c885de08" | ||
} | ||
] | ||
} | ||
}, | ||
"tags": [], | ||
"uuid": "4c170af9-61ac-4814-aff0-72689f052c9f" | ||
}, | ||
"tool_id": null, | ||
"type": "subworkflow", | ||
"uuid": "9d5600f9-b379-417a-aa5c-086dab49f683", | ||
"when": null, | ||
"workflow_outputs": [] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really worth it to have a subworkflow for just two simple steps?
one small cosmetic thing: we usually put the release near the top of the workflow between license and wf name. |
Thanks @paulzierep - I'll just send you the link to the workflow (in slack) so you can check it looks ok. |
FOR CONTRIBUTOR:
Workflow updates see Changelog