[BugFix] Fix queue checkpoint resume with lazy-initialized scalar buf…#401
Open
mohsinm-dev wants to merge 1 commit intogalilai-group:mainfrom
Open
[BugFix] Fix queue checkpoint resume with lazy-initialized scalar buf…#401mohsinm-dev wants to merge 1 commit intogalilai-group:mainfrom
mohsinm-dev wants to merge 1 commit intogalilai-group:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OrderedQueue/UnsortedQueue) is created withshape=None, theoutbuffer starts as(max_length, 1). After the firstappend()with scalar labels(B,), it becomes(max_length,). Oncheckpoint resume a fresh queue still has the
(max_length, 1)placeholder, causingload_state_dictto failwith a shape mismatch.
OrderedQueue.load_state_dictoverride was dead code during Lightning resume because PyTorch'srecursive loader calls
_load_from_state_dicton children, not theirload_state_dictoverride._load_from_state_dictto both queue classes andload_state_dicttoUnsortedQueuefor parity.Fixes #400