Updated examples and doc with new method.#179
Open
epokhcs wants to merge 4 commits intogalilai-group:mainfrom
Open
Updated examples and doc with new method.#179epokhcs wants to merge 4 commits intogalilai-group:mainfrom
epokhcs wants to merge 4 commits intogalilai-group:mainfrom
Conversation
Collaborator
|
Thank you for the PR! I'm not sure to understand what is the point of all these example files. |
Author
|
Should we keep them in one single file doc, just to show the different standard resolutions? |
Replace example stubs with an ENVIRONMENTS.md reference documenting the correct image_shape for each registered environment. Remove decord from dev dependencies as it has no macOS ARM64 wheels and is only needed by VideoDataset.
Decord is needed by VideoDataset on Linux/Windows. macOS users can skip it as documented in the README.
Author
|
Okay check ti now @lucas-maes |
Collaborator
|
Again, I'm not sure to understand what the contribution is here; we already have the environment in the docs. Not sure we want to add an extra environment.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I have fixed the constructor method information and readme for macosx.
Cheers!