✨ Quality: Robustness improvement - AsyncBlock sync throw handling#95
Conversation
- Wrapped promiseFn call in try-catch to handle synchronous exceptions - Added regression test for synchronous throws in AsyncBlock - Updated quality journal with learnings about handling synchronous throws in async props
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Added a try-catch block around the promiseFn call in AsyncBlock to handle synchronous throws.
🎯 Why: User-provided functions might throw synchronously before returning a promise, which would previously result in an unhandled exception or a stuck pending state.
📊 Impact: Makes AsyncBlock more robust against faulty promiseFn implementations.
✅ Verification: Added a regression test in lib/components/AsyncBlock/index.test.tsx.
PR created automatically by Jules for task 16943017556023473671 started by @galiprandi