Skip to content

Conversation

@Arukuen
Copy link

@Arukuen Arukuen commented Dec 15, 2025

…ut for file upload

fixes #9

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where interactions with the progress modal could accidentally dismiss it.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 15, 2025

Walkthrough

A mousedown event handler is added to the progress modal to prevent user interactions from dismissing the popover by calling preventDefault, stopPropagation, and stopImmediatePropagation. Existing rendering, progress updating, and close logic remain unchanged.

Changes

Cohort / File(s) Summary
Progress Modal Event Handling
src/admin/js/media-manager/progress-modal.js
Added mousedown event handler to suppress event propagation and prevent unintended popover dismissal

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

  • Single file with straightforward event handler addition
  • Event prevention logic is minimal and self-contained
  • Verify that preventDefault and stopPropagation appropriately target the intended interaction without blocking necessary modal functionality (e.g., confirming the modal can still be dismissed by intended close mechanisms)

Poem

A rabbit clicks with gentle care, 🐰
The modal stays, no need despair,
Events now still their wandering way,
Safe inside, the popover shall stay!


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 5ae075e and beabbd3.

📒 Files selected for processing (1)
  • src/admin/js/media-manager/progress-modal.js (1 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@bfintal
Copy link

bfintal commented Dec 15, 2025

@malalacharm please QA on whether the optimization progress modal can be closed (and other functionality if ever)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If the upload dropdown closes, the audio/video upload doesn't continue

3 participants