Fixed SetMinValue and SetMaxValue not changing min/max values.

[lextatic]

Fixes #12

Fixed

• Fixed typo in MinValue assertion.
• Fixed SetMinValue and SetMaxValue not actually changing min/max values.

Added

• Added new test cases for those methods.

Thanks @datouzhu125 for reporting!

[Copilot]

Pull request overview

Updates validation messaging in EntityAttribute.SetMinValue to correctly describe the invalid condition when a proposed minimum exceeds the current maximum.

Changes:

• Fixes the SetMinValue assertion message from “lower” to “greater” to match the newMinValue <= Max condition.

Comments suppressed due to low confidence (1)

Forge/Attributes/EntityAttribute.cs:122

• SetMinValue(int newMinValue) validates newMinValue but never assigns it to anything; Min is a get-only auto-property and the method clamps BaseValue using the existing Min value. As written, calling this method cannot change the attribute's min bound, which makes the API misleading and likely breaks callers (e.g., code expecting to update Min/Max at runtime). Consider either (a) making Min/Max backed by private fields and updating them here (and clamping BaseValue/CurrentValue against the new bounds), or (b) removing/renaming these methods and adjusting callers/docs if min/max are intended to be immutable.

		Validation.Assert(newMinValue <= Max, "MinValue cannot be greater than MaxValue.");

		var oldValue = CurrentValue;

		BaseValue = Math.Max(BaseValue, Min);

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.