Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds boolean expression resolvers to the Statescript property-resolver system, enabling composition of complex bool conditions directly in graph variable definitions and documenting their usage.
Changes:
- Introduces
AndResolver,OrResolver,NotResolver, andXorResolver(with shared operand type validation viaBooleanTypeUtils). - Adds unit tests covering resolver behavior, nesting, and operand-type validation.
- Updates Statescript documentation to describe the new resolvers and expands
ExpressionNodedocs to include them as validboolcondition inputs.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/statescript/resolvers/and-resolver.md | New documentation for AndResolver usage/behavior. |
| docs/statescript/resolvers/or-resolver.md | New documentation for OrResolver usage/behavior. |
| docs/statescript/resolvers/not-resolver.md | New documentation for NotResolver usage/behavior. |
| docs/statescript/resolvers/xor-resolver.md | New documentation for XorResolver usage/behavior. |
| docs/statescript/resolvers/README.md | Adds a “Boolean Expressions” section listing the new resolvers (and ComparisonResolver). |
| docs/statescript/nodes/condition/expression-node.md | Updates docs to reference composed boolean resolvers and refreshes the example. |
| Forge/Statescript/Properties/BooleanTypeUtils.cs | Adds shared validation helper for boolean operand resolvers. |
| Forge/Statescript/Properties/AndResolver.cs | Implements boolean AND resolver. |
| Forge/Statescript/Properties/OrResolver.cs | Implements boolean OR resolver. |
| Forge/Statescript/Properties/NotResolver.cs | Implements boolean NOT resolver. |
| Forge/Statescript/Properties/XorResolver.cs | Implements boolean XOR resolver. |
| Forge.Tests/Statescript/Resolvers/AndResolverTests.cs | Unit tests for AndResolver. |
| Forge.Tests/Statescript/Resolvers/OrResolverTests.cs | Unit tests for OrResolver. |
| Forge.Tests/Statescript/Resolvers/NotResolverTests.cs | Unit tests for NotResolver. |
| Forge.Tests/Statescript/Resolvers/XorResolverTests.cs | Unit tests for XorResolver. |
| Forge.Tests/Statescript/Nodes/Condition/ExpressionNodeTests.cs | Adds integration-style test verifying composed boolean resolvers work as ExpressionNode inputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added boolean expression resolvers.
booltrueonly when both boolean operands aretrue.boolbooltruewhen either boolean operand istrue.booltruewhen exactly one boolean operand istrue.