Added Immunity and RemoveOther effect components. - #51
Merged
lextatic merged 4 commits intoAug 1, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces target-side effect application vetoing via a blocker registry on EffectsManager, plus two new effect components built on EffectQuery: one to grant temporary immunity to incoming effects and one to remove other active effects on application.
Changes:
- Added
IEffectApplicationBlockerand anEffectsManagerregistry/event for vetoing effect applications (including instant effects). - Added
ImmunityEffectComponent(blocks incoming effects while active) andRemoveOtherEffectComponent(dispels/strips stacks on application). - Added validation, documentation, and test coverage for blockers and both query-driven components.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Forge/Effects/IEffectApplicationBlocker.cs | New interface for target-side veto of effect application. |
| Forge/Effects/EffectsManager.cs | Adds blocker registry, blocked-event, and consults blockers during application. |
| Forge/Effects/EffectData.cs | Adds validation rules for Immunity/RemoveOther configuration constraints. |
| Forge/Effects/Components/ImmunityEffectComponent.cs | New effect component that registers as a blocker while active. |
| Forge/Effects/Components/RemoveOtherEffectComponent.cs | New effect component that removes other active effects on apply. |
| Forge.Tests/Effects/EffectApplicationBlockerTests.cs | Tests registry semantics + event behavior for blockers. |
| Forge.Tests/Effects/ImmunityComponentTests.cs | Tests immunity behavior, inhibition interaction, and event reporting. |
| Forge.Tests/Effects/RemoveOtherComponentTests.cs | Tests removal behavior, stack removal, self-exclusion, and instants. |
| Forge.Tests/Effects/EffectQueryComponentsValidationTests.cs | Tests validation assertions for query-driven components. |
| docs/effects/README.md | Documents blocker registry and updates component list. |
| docs/effects/components/README.md | Adds guidance on when to use tag requirements vs Immunity/RemoveOther. |
| docs/effects/components/target-tag-requirements-effect-component.md | Adds cross-links to new guidance/components. |
| docs/effects/components/immunity-effect-component.md | New component documentation page. |
| docs/effects/components/remove-other-effect-component.md | New component documentation page. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lextatic
deleted the
feature/immunity-and-remove-other-effect-components
branch
August 1, 2026 03:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added