sbom-upload: re-exchange GCS token before set-release-status#1654
Merged
Conversation
Token obtained at job start expires (~25 min TTL) on long-running jobs (e.g. ls-dev with 1549 uploads takes ~1h47m), causing HTTP 401 on the status write. Add a refresh step immediately before set-release-status.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The GCS bearer token obtained at job start expires mid-run on long-running
jobs. The
Set release statusstep uses${{ inputs.gcs-token }}— thetoken evaluated at job startup — and has no awareness of the mid-run refresh
that
upload.pyperforms internally via System Trust. On jobs that run longerthan the token TTL (~25 min), the status write fails with HTTP 401
"Invalid Credentials".
Observed on
kubernetes-dev/landscape-dev-gardenwhosesbom-uploadjobtakes ~1h47m (1549 uploads + scan-missing). Staging (~30 min) is unaffected.
Result: SBOMs upload successfully but neither
promotednorreleasedstatusis written to the Cumulus GCS bucket for that run-key.
Fix
Add a
Refresh GCS token before status writestep immediately beforeSet release status, reusing the existingoidc-gcp-token-exchangeactionwith a distinct
token-env-prefix(GCS_STATUS_). TheSet release statusstep then prefers the freshly-issued token and falls back to the initial token
when token-exchange inputs are not provided (static-token callers).
The refresh step is guarded by
inputs.token-exchange-api-url != ''so it isa no-op for callers that do not supply exchange parameters.
Test plan
set-release-status: HTTP 200Release note: