Fix freeze when output text decoding fails#1573
Open
Raka-loah wants to merge 5 commits intogchq:masterfrom
Open
Fix freeze when output text decoding fails#1573Raka-loah wants to merge 5 commits intogchq:masterfrom
Raka-loah wants to merge 5 commits intogchq:masterfrom
Conversation
Fix possible browser freeze
|
|
C85297
changed the title
Member
|
I've replicated the issue here: https://gchq.github.io/CyberChef/#input=5L2g&oenc=54936 |
C85297
requested changes
Feb 4, 2026
Throws DishError when cptable.utils.decode fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cptable.utils.decodewill throw a Runtime Error instead of returning an error message string, soerrshould be changed toerr.message.Without the fix, whenever it fails to decode using given character encoding, the whole window freezes. For example, input a Chinese character 你 in UTF-8 and change output encoding to GB18030 will 100% freeze the browser.