Open
Conversation
Contributor
Author
|
Unit tests failed due to #1706, which is apparently still flaky. Just ran them locally (after upgrading to chromedriver@135.0.0 and nightwatch@3.12.1), all tests pass. |
Contributor
Author
|
@a3957273 Quick, the tests now pass! 😉 |
Move hint tooltip from label to form-group container element. This ensures that the tooltip is also displayed for form elements with an inline label, for which pointer-events are disabled (and rightly so) by Bootstrap Material Design. Logic applied to arguments of all types to ensure layout consistency.
Move jquery tooltip logic to the buildRecipeOperation function, so it is called regardless of whether the recipe is loaded from the url (which already worked correctly) or by dropping ingredients (which wasn't working before)
bartvanandel
force-pushed
the
fix/improve-hint-display
branch
from
5cb5b5d to
4125429
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2016