tests(#2406) by bruno-portfolio · Pull Request #2575 · gee-community/geemap

bruno-portfolio · 2026-02-03T19:22:11Z

Summary

Adds comprehensive unit test coverage for multiple modules as requested in #2406.

Changes

Module	Tests	Notes
test_cli.py	5	CLI with CliRunner
test_plot.py	44	bar_chart, line_chart, histogram, pie_chart
test_osm.py	39	All OSM functions
test_ml.py	25	sklearn integration
test_timelapse.py	46	GIF manipulation, timeseries
test_ai.py	71	AI module with mocked dependencies
test_foliumap.py	32	Skipped (module state issues)
test_kepler.py	28	Skipped (keplergl not available)
test_deck.py	19	✅ Passing
test_plotlymap.py	27	✅ Passing
test_maplibregl.py	23	Skipped (module state issues)
Total	398

Design Notes

Map modules use real widget libraries but mock Earth Engine calls
Module-level basemap initialization makes full mocking impractical
Graceful skip pattern for optional dependencies

Checklist

for more information, see https://pre-commit.ci

jdbcode · 2026-02-03T21:26:51Z

Thanks @bruno-portfolio! @schwehr can you take a look and see if this is what you had in mind?

schwehr · 2026-02-03T23:01:47Z

Thank you @bruno-portfolio! This is a great reference PR to start from.

First, apologies that docs/contributing.md is so out of date. I'll try to cover the process to get tests into geemap here and then we'll try to get the contributing.md updated.

Let's start with the simple and working test_cli.py. I verified it works for me locally:

python -m unittest discover -v tests test_cli.py
test_main_help_flag_shows_help (test_cli.TestMain.test_main_help_flag_shows_help) ... ok
test_main_help_flag_shows_usage (test_cli.TestMain.test_main_help_flag_shows_usage) ... ok
test_main_no_args_outputs_click_docs_reference (test_cli.TestMain.test_main_no_args_outputs_click_docs_reference) ... ok
test_main_no_args_outputs_message (test_cli.TestMain.test_main_no_args_outputs_message) ... ok
test_main_no_args_returns_zero (test_cli.TestMain.test_main_no_args_returns_zero) ... ok

----------------------------------------------------------------------
Ran 5 tests in 0.006s

OK

I've added comments you can use for that new PR.

tests/test_cli.py

bruno-portfolio · 2026-02-03T23:50:06Z

Thanks for the detailed feedback @schwehr!

I've applied your suggestions and created a separate PR with the corrected 'test_cli.py': #2579

tests/test_deck.py

schwehr · 2026-02-04T18:17:32Z

tests/test_deck.py

Please copy this file to a fresh branch and make a new PR with just test_deck.py

schwehr · 2026-02-04T18:17:49Z

Now that test_cli.py is in, how about test_deck.py? I confirmed it works locally for me:

source .venv/bin/activate

pip install pydeck

python -m unittest discover -v tests test_deck.py
test_add_basemap_valid (test_deck.TestAddBasemap.test_add_basemap_valid) ... ok
test_add_ee_layer_invalid_type_raises (test_deck.TestAddEeLayer.test_add_ee_layer_invalid_type_raises) ... ok
test_addlayer_alias (test_deck.TestAddEeLayer.test_addlayer_alias) ... ok
test_add_gdf_invalid_type_raises (test_deck.TestAddGdf.test_add_gdf_invalid_type_raises) ... ok
test_add_geojson_file_not_found_raises (test_deck.TestAddGeojson.test_add_geojson_file_not_found_raises) ... ok
test_add_kml_file_not_found_raises (test_deck.TestAddKml.test_add_kml_file_not_found_raises) ... ok
test_add_layer_pydeck_layer (test_deck.TestAddLayer.test_add_layer_pydeck_layer) ... ok
test_add_layer_url (test_deck.TestAddLayer.test_add_layer_url) ... ok
test_add_layer_with_name (test_deck.TestAddLayer.test_add_layer_with_name) ... ok
test_add_shp_file_not_found_raises (test_deck.TestAddShp.test_add_shp_file_not_found_raises) ... ok
test_add_vector_file_not_found_raises (test_deck.TestAddVector.test_add_vector_file_not_found_raises) ... ok
test_layer_init_default (test_deck.TestLayerInit.test_layer_init_default) ... ok
test_layer_init_hexagon (test_deck.TestLayerInit.test_layer_init_hexagon) ... ok
test_layer_init_with_data (test_deck.TestLayerInit.test_layer_init_with_data) ... ok
test_map_init_custom_center (test_deck.TestMapInit.test_map_init_custom_center) ... ok
test_map_init_custom_height_width (test_deck.TestMapInit.test_map_init_custom_height_width) ... ok
test_map_init_custom_map_style (test_deck.TestMapInit.test_map_init_custom_map_style) ... ok
test_map_init_custom_zoom (test_deck.TestMapInit.test_map_init_custom_zoom) ... ok
test_map_init_default_params (test_deck.TestMapInit.test_map_init_default_params) ... ok

----------------------------------------------------------------------
Ran 19 tests in 3.183s

OK

schwehr

Awesome to have test_deck.py in. How about test_plotlymap.py next?

schwehr · 2026-02-05T23:31:55Z

tests/test_plotlymap.py

@@ -0,0 +1,262 @@
+"""Tests for the plotlymap module."""
+
+from __future__ import annotations


Is this needed?

schwehr · 2026-02-05T23:34:00Z

tests/test_plotlymap.py

+except ImportError:
+    PLOTLY_AVAILABLE = False
+
+PLOTLYMAP_MODULE = None


Remove:

PLOTLYMAP_MODULE = None IMPORT_ERROR = None

schwehr · 2026-02-05T23:34:32Z

tests/test_plotlymap.py

+IMPORT_ERROR = None
+
+
+def get_plotlymap():


Remove this function

schwehr · 2026-02-05T23:35:42Z

tests/test_plotlymap.py

+class PlotlymapTestCase(unittest.TestCase):
+
+    @classmethod
+    def setUpClass(cls) -> None:


Remove setUpClass, tearDownClass, and setUp

schwehr · 2026-02-05T23:36:24Z

tests/test_plotlymap.py

+
+
+@unittest.skipUnless(PLOTLY_AVAILABLE, "plotly not available")
+class PlotlymapTestCase(unittest.TestCase):


Rename PlotlymapTestCase --> PlotlymapTest

schwehr · 2026-02-05T23:40:05Z

tests/test_plotlymap.py

+    def test_add_controls_string(self) -> None:
+        with mock.patch("geemap.coreutils.ee_initialize"):
+            m = self.plotlymap.Map(ee_initialize=False)
+            m.add_controls("drawline")


This and the tests below should be able to check that the action was taken.

schwehr · 2026-02-05T23:40:55Z

tests/test_plotlymap.py

+                url="https://tile.example.com/{z}/{x}/{y}.png",
+                name="Test Layer",
+                attribution="Test",
+            )


There needs to be an assert at the end that tests to see if the action worked.

schwehr · 2026-02-05T23:41:20Z

tests/test_plotlymap.py

+        with mock.patch("geemap.coreutils.ee_initialize"):
+            m = self.plotlymap.Map(ee_initialize=False)
+            layer = go.Scattermapbox(lat=[37.8], lon=[-122.4], name="test")
+            m.add_layer(layer, name="Test Layer")


Need an assert

schwehr · 2026-02-05T23:41:58Z

tests/test_plotlymap.py

+        with mock.patch("geemap.coreutils.ee_initialize"):
+            m = self.plotlymap.Map(ee_initialize=False)
+            layers = m.get_layers()
+            self.assertIsInstance(layers, dict)


What is the expected contents of layers in the default setup? What can be asserted? Same for the follow up tests.

schwehr · 2026-02-05T23:43:31Z

tests/test_plotlymap.py

+                    "value": [1.0, 0.5],
+                }
+            )
+            m.add_heatmap(df)


Assert something about the map that tests if the heatmap was added

schwehr

How about doing test_foliumap.py next.

Mostly the same comments before. A notable new thing is using with to create temps and have them automatically cleanup when the code exists the with scope.

schwehr · 2026-02-06T20:18:38Z

tests/test_foliumap.py

+except ImportError:
+    FOLIUM_AVAILABLE = False
+
+FOLIUMAP_MODULE = None


Remove these lines

FOLIUMAP_MODULE = None IMPORT_ERROR = None

schwehr · 2026-02-06T20:19:11Z

tests/test_foliumap.py

+IMPORT_ERROR = None
+
+
+def get_foliumap():


Remove this function and put the imports above in the try with import folium

schwehr · 2026-02-06T20:22:07Z

tests/test_foliumap.py

+                    }
+                ],
+            }
+            temp_path = os.path.join(self.temp_dir, "test.geojson")


Just do with tempfile.TemporaryDirectory() as tmpdir: here like in `test_common.py. And remove the temp dir stuff in the class setup.

schwehr · 2026-02-06T20:22:54Z

tests/test_foliumap.py

+    def test_to_html_saves_file(self) -> None:
+        with mock.patch("geemap.coreutils.ee_initialize"):
+            m = self.foliumap.Map(ee_initialize=False)
+            temp_path = os.path.join(self.temp_dir, "test_map.html")


Again use with to create the temp dir just for this test.

schwehr · 2026-02-06T20:23:44Z

tests/test_foliumap.py

+            temp_path = os.path.join(self.temp_dir, "test_map.html")
+            m.to_html(temp_path)
+            self.assertTrue(os.path.exists(temp_path))
+


Please assert something about the content for the file that is written.

schwehr · 2026-02-06T20:25:04Z

tests/test_foliumap.py

+class FoliumapTestCase(unittest.TestCase):
+
+    @classmethod
+    def setUpClass(cls) -> None:


Remove all the setup and teardown methods

schwehr · 2026-02-06T20:26:34Z

tests/test_foliumap.py

+        with mock.patch("geemap.coreutils.ee_initialize"):
+            with mock.patch("geemap.common.is_arcpy", return_value=False):
+                m = self.foliumap.Map(ee_initialize=False)
+                self.assertEqual(m.setCenter, m.set_center)


I don't think we need to test this. It's just an alias.

schwehr · 2026-02-06T20:26:56Z

tests/test_foliumap.py

+    def test_zoom_to_bounds_valid_bounds(self) -> None:
+        with mock.patch("geemap.coreutils.ee_initialize"):
+            m = self.foliumap.Map(ee_initialize=False)
+            m.zoom_to_bounds([-122.5, 37.5, -122.0, 38.0])


Assert something about the m instance that changed from the call.

schwehr · 2026-02-06T20:27:29Z

tests/test_foliumap.py

+                tiles="https://tile.example.com/{z}/{x}/{y}.png",
+                name="Test Layer",
+                attribution="Test",
+            )


Assert something for the change in m. Same for all the other tests the do a change. They all have to assert something about the change.

schwehr · 2026-02-06T20:28:21Z

tests/test_foliumap.py

+    def test_setcontrolvisibility_alias(self) -> None:
+        with mock.patch("geemap.coreutils.ee_initialize"):
+            m = self.foliumap.Map(ee_initialize=False)
+            self.assertEqual(m.setControlVisibility, m.set_control_visibility)


Also remove this alias check

schwehr · 2026-02-12T20:48:56Z

How about picking another test and doing the same style cleanup? Maybe test_osm.py?

Josue2747 and others added 2 commits February 3, 2026 16:12

tests(gee-community#2406)

4a40cad

[pre-commit.ci] auto fixes from pre-commit.com hooks

3b34c14

for more information, see https://pre-commit.ci

jdbcode requested a review from schwehr February 3, 2026 21:25

jdbcode assigned schwehr Feb 3, 2026

schwehr requested changes Feb 3, 2026

View reviewed changes

tests/test_cli.py Show resolved Hide resolved

tests/test_cli.py Show resolved Hide resolved

tests/test_cli.py Show resolved Hide resolved

tests/test_cli.py Show resolved Hide resolved

schwehr reviewed Feb 3, 2026

View reviewed changes

tests/test_cli.py Show resolved Hide resolved

schwehr requested changes Feb 4, 2026

View reviewed changes

bruno-portfolio mentioned this pull request Feb 4, 2026

tests(#2406): add test_deck.py #2580

Merged

schwehr requested changes Feb 5, 2026

View reviewed changes

schwehr requested changes Feb 6, 2026

View reviewed changes

bruno-portfolio mentioned this pull request Feb 12, 2026

tests(#2406): add test_osm.py #2604

Open

		@@ -0,0 +1,262 @@
		"""Tests for the plotlymap module."""

		from __future__ import annotations



		@unittest.skipUnless(PLOTLY_AVAILABLE, "plotly not available")
		class PlotlymapTestCase(unittest.TestCase):

Uh oh!

Conversation

bruno-portfolio commented Feb 3, 2026

Summary

Changes

Design Notes

Checklist

Uh oh!

jdbcode commented Feb 3, 2026

Uh oh!

schwehr commented Feb 3, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bruno-portfolio commented Feb 3, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

schwehr commented Feb 4, 2026

Uh oh!

schwehr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

schwehr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

schwehr commented Feb 12, 2026

Uh oh!