-
Notifications
You must be signed in to change notification settings - Fork 1
Add results endpoint to download a static html file #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you format all files using black from the recommanded extensions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The html file is missing the mapping information. Maybe this is related to the css definition not being included in the file?
And what was the reason for you to create a fork for working on the changes instead of creating a simple branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also rebase on the latest state of main to enforce checks
I did not have the necessary rights, so I was forced to create a fork |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to validate some information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the type mismatch and also remove commented out code :)
).config.html_output_dir | ||
|
||
return create_results_html( | ||
mappingDict, html_output_dir, show_remarks, show_warnings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is some strange mismatch here between types. mapping
in mappingDict
is of type MappingDetailsModel
and create_results_html
expects Mapping
. In the implementation of create_results_html
the variable of type Mapping
is used like MappingDetailsModel
, which causes the linter to go wild. I think what you really intended was the function create_result_html
to receive a variable of type MappingDetailsModel
.
Please adjust the type in the function description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I have adjusted it
This pull request creates a new endpoint that returns the mapping structure as a static html page.
The function that generates the html file has also been migrated to the new data model.