Skip to content

Conversation

Hendrejvr
Copy link

This pull request creates a new endpoint that returns the mapping structure as a static html page.

The function that generates the html file has also been migrated to the new data model.

@Hendrejvr Hendrejvr changed the title add results endpoint to download a static html file Add results endpoint to download a static html file Jun 18, 2025
Copy link
Contributor

@cybernop cybernop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you format all files using black from the recommanded extensions?

Copy link
Contributor

@cybernop cybernop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The html file is missing the mapping information. Maybe this is related to the css definition not being included in the file?

@cybernop
Copy link
Contributor

And what was the reason for you to create a fork for working on the changes instead of creating a simple branch?

Copy link
Contributor

@cybernop cybernop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also rebase on the latest state of main to enforce checks

@Hendrejvr
Copy link
Author

And what was the reason for you to create a fork for working on the changes instead of creating a simple branch?

I did not have the necessary rights, so I was forced to create a fork

@Hendrejvr Hendrejvr requested a review from cybernop August 8, 2025 09:41
Copy link
Contributor

@cybernop cybernop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to validate some information

Copy link
Contributor

@cybernop cybernop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the type mismatch and also remove commented out code :)

).config.html_output_dir

return create_results_html(
mappingDict, html_output_dir, show_remarks, show_warnings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is some strange mismatch here between types. mapping in mappingDict is of type MappingDetailsModel and create_results_html expects Mapping. In the implementation of create_results_html the variable of type Mapping is used like MappingDetailsModel, which causes the linter to go wild. I think what you really intended was the function create_result_html to receive a variable of type MappingDetailsModel.

Please adjust the type in the function description.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I have adjusted it

@Hendrejvr Hendrejvr requested a review from cybernop September 5, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants