feat: Add support for Google Shared Drives by including `supportsAllDrives` and `includeItemsFromAllDrives` parameters in Drive API calls. #178

raybell-md · 2026-01-27T01:17:49Z

Fixes #158

…rives` and `includeItemsFromAllDrives` parameters in Drive API calls.

gemini-code-assist · 2026-01-27T01:18:07Z

Summary of Changes

Hello @raybell-md, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces functionality to interact with Google Shared Drives. It achieves this by modifying existing Google Drive API calls within the DriveService to include specific parameters that enable access to and manipulation of Shared Drive content. The changes are accompanied by updated and new unit tests to ensure the correct application of these parameters.

Highlights

Google Shared Drive Support: Implemented support for Google Shared Drives by adding supportsAllDrives: true and includeItemsFromAllDrives: true parameters to relevant Google Drive API calls.
API Call Modifications: Modified files.list, files.create, and files.get methods within DriveService to include the necessary parameters for interacting with Shared Drives.
Unit Test Enhancements: Updated existing unit tests and added new test cases to verify that the Google Drive API calls correctly include the supportsAllDrives and includeItemsFromAllDrives flags, ensuring proper functionality with Shared Drives.
Dependency Metadata Update: Updated package-lock.json to include peer: true for several development dependencies, likely reflecting an update to the dependency tree or a change in how peer dependencies are managed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

The pull request successfully implements support for Google Shared Drives by adding the supportsAllDrives and includeItemsFromAllDrives parameters to the relevant Google Drive API calls in DriveService.ts. The accompanying test file, DriveService.test.ts, has been appropriately updated with new test cases and assertions to validate this new functionality. The changes are well-aligned with the stated objective of the pull request.

raybell-md · 2026-01-27T03:35:04Z

something not right but can't work out what. Getting getting ✕ MCP ERROR (google-workspace) when testing.
Looks like auth not showing up
(#30 (comment))

raybell-md · 2026-01-27T04:29:41Z

Other that it acting weird with OAuth when testing once I fixed that it worked as expected.

Ready for review

Prakul95 · 2026-01-28T08:17:07Z

workspace-server/src/__tests__/services/DriveService.test.ts


      mockDriveAPI.files.get.mockImplementation((params: any) => {
        if (params.alt === 'media') {
-            return Promise.resolve({


nit: unrelated

Prakul95 · 2026-01-28T08:17:29Z

workspace-server/src/__tests__/services/DriveService.test.ts

+          });
        }
        return Promise.resolve({
-            data: { id: mockFileId, name: 'test.txt', mimeType: 'text/plain' },


unrelated nit

Prakul95 · 2026-01-28T08:19:00Z

workspace-server/src/services/DriveService.ts

                q = "sharedWithMe";
            }
        }
-        


Prakul95 · 2026-01-28T08:19:17Z

workspace-server/src/services/DriveService.ts

        logToFile(`Downloading Drive file ${fileId} to ${localPath}`);
        try {
            const drive = await this.getDriveClient();
-            


Prakul95 · 2026-01-28T08:19:27Z

workspace-server/src/services/DriveService.ts

            }

            if (mimeType.includes('vnd.google-apps.')) {
-                 return {


Prakul95 · 2026-01-28T08:19:37Z

workspace-server/src/services/DriveService.ts

            // 3. Save to localPath
            const absolutePath = path.isAbsolute(localPath) ? localPath : path.resolve(PROJECT_ROOT, localPath);
            const dir = path.dirname(absolutePath);
-            


Prakul95 · 2026-01-28T08:45:50Z

I think your changes should be added to docs, sheets and slides search as well

Revert indentation nits in DriveService

raybell-md · 2026-01-28T13:39:38Z

Thanks @Prakul95 reverted the nits. I also opened #180 as it can help avoid AI fixing this on every PR

raybell-md · 2026-01-28T13:42:45Z

I think your changes should be added to docs, sheets and slides search as well

Probably. Want to open an issue? I like small PRs and don't want to include those in this one

feat: Add support for Google Shared Drives by including `supportsAllD…

a447ac6

…rives` and `includeItemsFromAllDrives` parameters in Drive API calls.

gemini-code-assist bot reviewed Jan 27, 2026

View reviewed changes

Update package-lock.json

a487e2d

Prakul95 reviewed Jan 28, 2026

View reviewed changes

workspace-server/src/services/DriveService.ts

q = "sharedWithMe";

}

}

Copy link

Prakul95 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Prakul95 reviewed Jan 28, 2026

View reviewed changes

workspace-server/src/services/DriveService.ts

}

if (mimeType.includes('vnd.google-apps.')) {

return {

Copy link

Prakul95 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Prakul95 reviewed Jan 28, 2026

View reviewed changes

style: revert indentation nits to match project conventions

bf0395d

raybell-md mentioned this pull request Jan 28, 2026

Revert indentation nits in DriveService raybell-md/workspace#5

Merged

Merge pull request #5 from raybell-md/fix/nit-reverts

8f75c95

Revert indentation nits in DriveService

feat: Add support for Google Shared Drives by including supportsAllDrives and includeItemsFromAllDrives parameters in Drive API calls. #178

Are you sure you want to change the base?

feat: Add support for Google Shared Drives by including supportsAllDrives and includeItemsFromAllDrives parameters in Drive API calls. #178

Conversation

raybell-md commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Jan 27, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

raybell-md commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

raybell-md commented Jan 27, 2026

Uh oh!

Prakul95 Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Prakul95 Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Prakul95 Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Prakul95 Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Prakul95 Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Prakul95 Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Prakul95 commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

raybell-md commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

raybell-md commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat: Add support for Google Shared Drives by including `supportsAllDrives` and `includeItemsFromAllDrives` parameters in Drive API calls. #178

feat: Add support for Google Shared Drives by including `supportsAllDrives` and `includeItemsFromAllDrives` parameters in Drive API calls. #178

raybell-md commented Jan 27, 2026 •

edited

Loading

raybell-md commented Jan 27, 2026 •

edited

Loading

Prakul95 commented Jan 28, 2026 •

edited

Loading

raybell-md commented Jan 28, 2026 •

edited

Loading