Open
Conversation
|
@zaidka think we can also merge this? Super useful to have the ability to Reboot & FR on simulators |
Member
|
I hate to be blunt, but the commented out test code, the various formatting issues and unnecessary changes don't inspire confidence. I understand you've probably tested it and confirmed it works for you, but I take a clean but broken solution over a messy but working one any day. If you can clean it up and make sure you're not making more changes than really necessary, I'd be happy to take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes :
Additional :