Rebase forked repo to include main fork changes from past 3 years #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workflows for generators
changed pattern to work with acronyms in underscore conversion
Add #[\ReturnTypeWillChange] (https://php.watch/versions/8.1/ReturnTypeWillChange) to avoid deprecation notices.
Add support for okhttp4-gson as a replacement for okhttp-gson okhttp-gson is based on okhttp 2.x which is no longer supported. okhttp 3.x is also [not supported anymore](https://square.github.io/okhttp/security/security/) Creating a new target for codegen since okhttp 4.x is a breaking change over the okhttp 2.x with the changed package names. The overall change is similar to the existing code with a few updates - updates due to deprecations documented in https://square.github.io/okhttp/changelogs/changelog_3x/#version-300-rc1 - kept the utility methods in the existing code as-is tested `mvn package`, ran the petstore generation scripts and the integration tests that are generated Fixes #9606
Add okhttp4-gson codegen
Before bugfix: a required and nullable attribute set to null/None causes a value error when received by the client. After bugfix: This error is only caused for properties being required and not nullable General info: The python client cannot distinguish between unset attributes (value=None) and attributes set to null (value=None) Authored-by: MalteEbner <[email protected]>
* Don't set logging stream handler in library code Closes #8263 * Update python-petstore and petstore-security-test samples Co-authored-by: Nick Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)