-
Notifications
You must be signed in to change notification settings - Fork 0
group incidents by year #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Might even be worthwile to use nested |
|
Good idea @asteiner-swisstopo . |
|
P.S.: for the test link to reflect the most recent changes, it helps to add a dummy query param to bypass cache: https://sys-docs.dev.bgdi.ch/preview/feat_group_incidents_by_year/page/status-page.html?_=dummyvalue |
|
Cool thanks, looks as expected. Seeing it now, maybe it would be even cleaner to extract it to a separate subpage without collapsible blocks. I don't really see the advantage of having to click every section in order to be able to read it. So we would have two pages:
But no strong opinion, I let you decide. What you should fix for sure: The numbering in the README, currently each steps starts with "1.". |
|
Having subpages might be an option. How about the new commit: The incidents, grouped by year, are still on the same page. |
now grouping incidents by year and only expanding the current year by default, to improve readability. Esp. useful in years with many incidents
- Group incidents by year - Group incidents themselves, only keeping the most current / recent one expanded by default - Added a section on how to add a new incident to the status page in the README.md
Now we have three levels of containers. One that starts with 5 colons for the years, another one starting with 4 colons for the incidents and a last one, starting with 3 colons for the potentially multipe messages inside the same incident. Also, everything is collapsed by default
6307bae to
eb5cca2
Compare

Suggestion:
How about grouping incidents by year and only expanding the current year by default, to improve readability?
Esp. useful in years with many incidents
Test link