-
Notifications
You must be signed in to change notification settings - Fork 249
Advanced 2D-Subduction cookbook with reactive fluid transport #6455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Advanced 2D-Subduction cookbook with reactive fluid transport #6455
Conversation
650605d
to
f6d6c66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some initial thoughts:
You made the checklist with all the cases you want to add; would it make sense to split this into two cookbooks? One being instantaneous and one being time-dependent? Just to make the files and the pull requests smaller.
I know this is WIP, but the images look really cool already!
cookbooks/2D_subduction_with_two_phase_flow/plugin/world_builder_disequilibrium_fluid.cc
Outdated
Show resolved
Hide resolved
cookbooks/2D_subduction_with_two_phase_flow/plugin/world_builder_disequilibrium_fluid.cc
Outdated
Show resolved
Hide resolved
cookbooks/2D_subduction_with_two_phase_flow/plugin/world_builder_disequilibrium_fluid.cc
Outdated
Show resolved
Hide resolved
cookbooks/2D_subduction_with_two_phase_flow/plugin/world_builder_disequilibrium_fluid.cc
Outdated
Show resolved
Hide resolved
cookbooks/2D_subduction_with_two_phase_flow/plugin/world_builder_disequilibrium_fluid.cc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danieldouglas92 -I second @jdannberg that although this is a WIP the initial results are really cool and this will make a great cookbook. Nice work! I've left some initial comments and suggestions to consider as you work on expanding out the cookbook.
cookbooks/2D_subduction_with_two_phase_flow/doc/2D_subduction_two_phase_flow.md
Outdated
Show resolved
Hide resolved
cookbooks/2D_subduction_with_two_phase_flow/doc/2D_subduction_two_phase_flow.md
Outdated
Show resolved
Hide resolved
cookbooks/2D_subduction_with_two_phase_flow/fixed_slab_mckenzie_with_fugacity.prm
Outdated
Show resolved
Hide resolved
cookbooks/2D_subduction_with_two_phase_flow/fixed_slab_mckenzie_with_fugacity.prm
Outdated
Show resolved
Hide resolved
cookbooks/2D_subduction_with_two_phase_flow/fixed_slab_mckenzie_with_fugacity.prm
Show resolved
Hide resolved
cookbooks/2D_subduction_with_two_phase_flow/plugin/world_builder_disequilibrium_fluid.cc
Outdated
Show resolved
Hide resolved
cookbooks/2D_subduction_with_two_phase_flow/plugin/world_builder_disequilibrium_fluid.cc
Outdated
Show resolved
Hide resolved
cookbooks/2D_subduction_with_two_phase_flow/plugin/world_builder_disequilibrium_fluid.cc
Outdated
Show resolved
Hide resolved
cookbooks/2D_subduction_with_two_phase_flow/plugin/world_builder_disequilibrium_fluid.cc
Show resolved
Hide resolved
aadde7d
to
e4e080a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danieldouglas92 - A few more minor comments from my end, but I think is otherwise very close. Please let me know when it is ready for a final review!
cookbooks/2D_subduction_with_two_phase_flow/doc/2D_subduction_two_phase_flow.md
Outdated
Show resolved
Hide resolved
cookbooks/2D_subduction_with_two_phase_flow/doc/2D_subduction_two_phase_flow.md
Outdated
Show resolved
Hide resolved
aeb65ab
to
6beb8f2
Compare
The text is ready for another look, I just need to update the figures (same figure ideas, just new model output)! I was having issues with convergence with the fully coupled models, so my thoughts are to try to merge what is currently here, which is just the results and discussion of the darcy advection case, and then add the output and discussion for the mckenzie advection case in a follow up PR. Does that sound reasonable @jdannberg @naliboff? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danieldouglas92 - I just read through the cookbook again and it is in great shape.
A few questions and suggestions for how to proceed:
-
Would you like to merge this cookbook in pieces, or wait until all the components outlined in the first comment are ready?
-
If you prefer to merge it in pieces (that would be my preference), maybe make an associated issue that can keep track of individual components and associated PRs?
-
Again, if you prefer to merge in pieces, then this PR would just need an change log, ideally a test case, and perhaps squashing some of the commits. Other than that, this is in great shape and nice work!
e3ef555
to
f62fb8d
Compare
@naliboff I think merging the different extensions of the cookbooks as follow up PR's makes the most sense. I can definitely make a tracking issue for that. I've squashed all the commits and added a change log, I'll add a test case shortly. |
No rush, but this is ready for another look! @naliboff @jdannberg |
6af23bd
to
49c83f3
Compare
49c83f3
to
997b1b4
Compare
Implement a cookbook which demonstrates reactive fluid transport in a 2D subduction model. The cookbook will have multiple different setups:
A cookbook which keeps the temperature, and all compositions (except for the porosity) as static fields. The bound fluid will not be allowed to decrease, acting as a constant fluid source within a stationary slab that is initialized with the Geodynamic WorldBuilder. The fluid will advect according to the Darcy advection scheme. This will be a step above in complexity from the cookbook Simplified Subduction Model with Parameterized Solid-Fluid Reactions because there is no velocities being prescribed within the slab or mantle wedge.
Repeat the above with viscous weakening from the water fugacity term implemented here to investigate the impact of this coupling
Repeat the above two steps with the fluid being advected according to the fully coupled McKenzie equations.
A dynamic 2D subduction model that begins with a small subducted segment and runs for ~10-20 Myr. The fluid would be advected with the Darcy velocity.
Repeat the above step with viscous weakening from the water fugacity
Repeat the above two steps with the fluid advected according to the fully coupled McKenzie equations.