Use Darcy Velocity in entropy_viscosity.cc#6937
Open
danieldouglas92 wants to merge 4 commits intogeodynamics:mainfrom
Open
Use Darcy Velocity in entropy_viscosity.cc#6937danieldouglas92 wants to merge 4 commits intogeodynamics:mainfrom
danieldouglas92 wants to merge 4 commits intogeodynamics:mainfrom
Conversation
danieldouglas92
force-pushed
the
use_darcy_velocity_for_diffusion
branch
from
29e2baf to
631fe38
Compare
Contributor
Author
|
Tests that are failing all use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a field is advected with the
darcy fieldadvection method, I realized when doing some tests where I changed the stabilization parameterscRandbetathat they didn't seem to have much of an influence on the diffusion of theporositycomposition, especially when compared to the same test with theporosityadvected with the McKenzie equations. It turns out that the Darcy velocity was never computed when calculating the entropy viscosity, and so the solid velocity was always used.This PR modifies
entropy_viscosity.ccto account for the Darcy velocity when advecting a field with thedarcy fieldadvection method.