[WIP] Use fully distributed vector in line search#6939
Closed
gassmoeller wants to merge 1 commit intogeodynamics:mainfrom
Closed
[WIP] Use fully distributed vector in line search#6939gassmoeller wants to merge 1 commit intogeodynamics:mainfrom
gassmoeller wants to merge 1 commit intogeodynamics:mainfrom
Conversation
Member
Author
|
deal.II patch is merged. this can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another follow-up PR to #6910.
Inside the
perform_line_searchfunction it looks like we no longer write into ghosted vectors, however the.saddimplementation for Tpetra vectors internally does, if the added vector is a ghosted vector. That is becausesaddcreates a copy of the added vector and then scales that copy. Therefore if the added vector is ghosted, the copy is ghosted, and modifying that copy is then not allowed.This can (and should) be fixed in deal.II that is why I marked this as WIP here (I just want to document the problem and where it appears in ASPECT). When a proper patch is merged in deal.II this PR can be closed.