Standard / ISO19115-3 / Metadata linkage readonly for multilingual records

[fxprunayre]

Follow up of #9167.

6c3535f reported an issue for multilingual record.

Make the metadata linkage readonly (completeMetadata) also if record is multilingual.

Checklist

• I have read the contribution guidelines
• Pull request provided for main branch, backports managed with label
• Good housekeeping of code, cleaning up comments, tests, and documentation
• Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
• Clean commit messages, longer verbose messages are encouraged
• API Changes are identified in commit messages
• Testing provided for features or enhancements using automatic tests
• User documentation provided for new features or enhancements in manual
• Build documentation provided for development instructions in README.md files
• Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[fxprunayre]

Hi @cmangeat, I was addressing the issue you mentionned in 6c3535f but BuildEditorFormTest fails even if editing
https://github.com/geonetwork/core-geonetwork/blob/main/schemas/iso19115-3.2018/src/test/resources/UpperRhineCastles-iso19115-3.2018.xml works fine (all views). The test is based on https://github.com/geonetwork/core-geonetwork/blob/main/schemas/iso19115-3.2018/src/test/resources/raw-UpperRhineCastles-inflated-for-edition.xml - do you have any helper to generate the "inflated" version from the original XML which should be UpperRhineCastles-iso19115-3.2018.xml ? Any pointer welcomed.

[cmangeat]

Hi @cmangeat, I was addressing the issue you mentionned in 6c3535f but BuildEditorFormTest fails even if editing https://github.com/geonetwork/core-geonetwork/blob/main/schemas/iso19115-3.2018/src/test/resources/UpperRhineCastles-iso19115-3.2018.xml works fine (all views). The test is based on https://github.com/geonetwork/core-geonetwork/blob/main/schemas/iso19115-3.2018/src/test/resources/raw-UpperRhineCastles-inflated-for-edition.xml - do you have any helper to generate the "inflated" version from the original XML which should be UpperRhineCastles-iso19115-3.2018.xml ? Any pointer welcomed.

Hello, as I remember, "inflated" version was generated using a vanillia gn, using such a snippet before the transformation (at the beginning of Xml.transform(...)):

XMLOutputter xmlOutputter = new XMLOutputter(Format.getCompactFormat());
String rawXml = xmlOutputter.outputString(xml);
FileWriter fw = new FileWriter(".../schemas/iso19115-3.2018/src/test/resources/raw-UpperRhineCastles-inflated-for-edition.xml");
fw.write(rawXml);
fw.flush();

• compact format has to be chosen as used deserialisation to dom tree add empty element for "\n" if not chosen
• a few entries has then to be obfuscated then so to please github and avoid "security disclosures" (mail account for example, but NOT password as they are not embedded)

The file is NOT updated regularly, could have also occurred that a section has been updated manually at a given moment.

Please also remember that patching input in test is also simple, cf. https://github.com/metadata101/iso19115-3.2018.che/blob/4.4.9/src/test/java/org/fao/geonet/schema/BuildEditorFormTest.java#L119.

"Any tests are better than no tests." ?