Skip to content

Conversation

@b4l
Copy link
Member

@b4l b4l commented Aug 23, 2023

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

@urschrei
Copy link
Member

Similar to my comment in #1057, could you say a little about how this improvement works?

@b4l
Copy link
Member Author

b4l commented Aug 25, 2023

Theoretically, it should be an improvement as it may use fewer orientation invocations. The benches show mixed results though, with gains in the synthetic one while regressing the real-world ones, hence a draft. It may need a certain amount of points to become beneficial.

@frewsxcv
Copy link
Member

Thanks for opening this @b4l. My opinion is that we'll only consider a change like this if we can consistently see it being a performance win in the benches. So considering that, and that momentum has slowed on this pull request, I'm going to close it. If you feel like picking this back up, feel free to reopen.

@frewsxcv frewsxcv closed this Oct 26, 2025
@b4l
Copy link
Member Author

b4l commented Oct 27, 2025

@frewsxcv, that is fine. I just left it like this in case someone else follows this path. Should the branch be deleted or kept?

@frewsxcv frewsxcv deleted the ch branch October 27, 2025 18:13
@frewsxcv
Copy link
Member

I'll delete it but we can easily restore it if someone else picks it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants