Refactor scheduled function execution to use explicit timing control#82
Draft
ianmacartney wants to merge 6 commits intomainfrom
Draft
Refactor scheduled function execution to use explicit timing control#82ianmacartney wants to merge 6 commits intomainfrom
ianmacartney wants to merge 6 commits intomainfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
964b72d to
4864881
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Refactor scheduled function execution to use explicit scheduling instead of setTimeout
This change replaces the setTimeout-based scheduled function execution with an explicit scheduling system that provides better control over test timing.
Key Changes:
Explicit execution control: Scheduled functions are no longer automatically executed via setTimeout. Instead, they are executed explicitly through
finishInProgressScheduledFunctions()andfinishAllScheduledFunctions()Function path resolution: Added
scheduledFunctionPathsmap to track resolved function paths for function handles that may target different components than where the job is storedImproved timer compatibility: Uses empty setTimeout calls as time markers that work with
vi.advanceTimersByTime()andvi.runAllTimers()for precise test controlSequential execution: Functions are now executed one at a time in order of scheduled time, with proper state management and error handling
Enhanced test utilities:
finishInProgressScheduledFunctions()now runs pending functions whose scheduled time has passed and waits for in-progress functionsfinishAllScheduledFunctions()executes all pending functions in chronological order while advancing time as neededThis approach provides deterministic scheduled function execution in tests while maintaining compatibility with fake timer utilities.