Added functions to list all users with recent rooms #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eswaldots is attempting to deploy a commit to the Convex Team on Vercel. A member of the Team first needs to authorize it. |
| .withIndex("room_order", (q) => q.eq("roomId", roomId).eq("online", false)) | ||
| .order("desc") | ||
| .take(limit - online.length); | ||
| .query("presence") |
Collaborator
There was a problem hiding this comment.
Probably need to run prettier here.
| }, | ||
| }); | ||
|
|
||
| export const listAllUsers = query({ |
Collaborator
There was a problem hiding this comment.
A bit concerned about exposing this directly via the API since it'll likely hit limits pretty quickly for many applications. One alternative would be to paginate the responses from this. The other would be to just have a listRooms function that lists the rooms and then these can be used with listRoom to get the users in each. That would keep cross-room operations to a minimum and minimize any contention in operations between rooms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
listAllUsersmethod to presence component, so other people (like administrators) can register an see the activity of people without have to filtering by roomId or userId.