Repository navigation
fix(aws): use VPC ID for scoped Karpenter discovery - #37
Merged
Vignesh (vigneshr-07) merged 1 commit intoSep 23, 2026
Merged
Vignesh (vigneshr-07) merged 1 commit into
Vignesh (vigneshr-07) merged 1 commit into
Conversation
Jigar Patel (jiggy-ditto)
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
karpenter.sh/discovery, even whencluster_nameis set. Preserve explicit overrides and legacy non-scope behavior.Why
v2-vnext-testnode subnets were tagged with the scope's cluster name, while the Valet EKS chart configured Karpenter to select the VPC ID. Karpenter therefore finds no subnets and cannot provision workers. The same mismatch would affect a future named non-default prod scope.References
Test plan
The full Go suite has an unrelated macOS temp-path test failure.