Bump Ditto dependency to 4.12.3 #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflow was using flutter-version: "stable" which caused the action to interpret "stable" as both the version and channel, resulting in the error "Unable to determine Flutter version for channel: stable version: stable". Fixed by using flutter-version: '3.x' with channel: 'stable', matching the pattern used in the flutter-ci.yml workflow.
pvditto
requested review from
a team,
busec0,
cameron1024,
konstantinbe,
kristopherjohnson and
teodorciuraru
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Reverted changes that I had included for testing and forgot to remove again. |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 17 out of 30 changed files in this pull request and generated no new comments.
Files not reviewed (2)
- javascript-tui/package-lock.json: Language not supported
- javascript-web/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Hello, it's me from beyond the grave 👋 💀 I think I may need to be removed from codeowners or something (or maybe just unassigned from this PR? not sure exactly - but I am still in codeowners). Anyways Flutter changes LGTM 😢 🫡 |
busec0
approved these changes
Oct 15, 2025
teodorciuraru
approved these changes
Oct 15, 2025
kristopherjohnson
approved these changes
Oct 16, 2025
phatblat
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes a minor workflow fix.
The test failures are CI issues AFAICT.