-
Notifications
You must be signed in to change notification settings - Fork 0
CX-549: Query Editor #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a comprehensive Query Editor feature for executing DQL (Document Query Language) queries against the Ditto store, providing a complete interface for query input, execution, and results display with performance optimizations for large datasets.
- Introduces a new QueryEditor component with multi-line text input, execution controls, and virtualized results display
- Implements useQueryExecution hook for managing query execution, results processing, and export functionality
- Replaces emoji-based icons with text symbols throughout the library for zero-setup compatibility
Reviewed Changes
Copilot reviewed 22 out of 26 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.ts | Exports new QueryEditor components and useQueryExecution hook |
| src/hooks/useQueryExecution.ts | Core hook for DQL query execution with memory management and export features |
| src/hooks/index.ts | Adds useQueryExecution to hook exports |
| src/components/*.tsx | New QueryEditor, QueryEditorView, QueryResultsView, and QueryHeaderView components |
| src/components/index.ts | Exports new query editor components and type definitions |
| src/components/SystemSettings.tsx | Replaces emoji refresh icons with text symbols |
| src/components/PeersList.tsx | Replaces emoji warning icon with text |
| src/components/DiskUsage.tsx | Replaces emoji warning icon with text |
| example/* | Integration of QueryEditor into example app with navigation and screen setup |
| README.md | Comprehensive documentation for new QueryEditor component |
Files not reviewed (1)
- example/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 21 out of 25 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- example/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Summary
This PR adds a comprehensive Query Editor feature to the React Native Ditto Tools library, enabling DQL (Document Query Language) execution with a complete interface for query input, execution, and results display.
New Components Added
Core Components
Hook Implementation
Key Features
Query Input and Execution
Results Display
Export Functionality
Memory Management
Style Customization
Complete style customization through props:
stylepropExample App Integration
Text-Based Interface
Testing
QueryEditor.mp4