HTTP175 Remove headers and responses from logs #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: davidradl <[email protected]>
grzegorz8
reviewed
Oct 18, 2025
|
|
||
| this.httpPostRequestCallback.call(response, request, "endpoint", Collections.emptyMap()); | ||
|
|
||
| request.getHttpRequest().uri(); |
There was a problem hiding this comment.
The result of request.getHttpRequest().uri() is ignored. What is the purpose of this statement?
| String requestBody = requestEntry.getElements().stream() | ||
| .map(element -> new String(element, StandardCharsets.UTF_8)) | ||
| .collect(Collectors.joining()); | ||
| // Uncomment if you want to see the requestBody in the log |
There was a problem hiding this comment.
Maybe we should define two Callbacks?
- one implementation logs the entire request/response, including headers.
- second implementation skips sensitive parts such as headers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove HTTP headers and responses from logs. I have left the lookup keys, uris and http status codes in the logging as these are very unlikely to be sensitive
Resolves
HTTP-175PR Checklist