-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Turkish Language Support #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughA new Turkish localization file has been added, providing full Turkish language support for the application's UI. Additionally, the Turkish language option ("tr") has been appended to the language selection menu in all existing locale files (English, German, Spanish, Japanese, and Chinese). The placeholder syntax for API key error messages was standardized from Changes
Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (7)
public/locales/ja.json (1)
604-605
: Turkish entry looks good – optional key ordering tweak
"tr": "トルコ語"
is correct and the trailing comma on the"de"
line keeps the JSON valid.
For consistency and smaller diffs down the road, consider sorting thelanguage_menu
keys alphabetically (e.g.de, en, es, ja, tr, zh
) in every locale file.public/locales/zh.json (1)
604-605
: 新增土耳其语项 👍 – 可选: 统一按键名排序
"tr": "土耳其语"
译名准确,语法无误。
同样可酌情将language_menu
的键按字母顺序统一,方便后续维护。public/locales/es.json (1)
604-605
: Entrada de “Turco” correcta – sugerencia menor de ordenaciónLa clave y la traducción son correctas.
Como detalle, ordenar alfabéticamente las claves del menú (de, en, es, ja, tr, zh
) evitará futuros conflictos de merge.public/locales/en.json (1)
616-617
: “Turkish” added correctly – keep an eye on key orderNothing functionally wrong here.
If you decide to alphabetise the keys, move"de"
/"tr"
to maintain a consistent sequence across locale files.public/locales/de.json (1)
603-604
: Eintrag „Türkisch“ passt – optionale Sortier-OptimierungÜbersetzung stimmt.
Kleine Pflege-Idee: die Schlüssel inlanguage_menu
überall alphabetisch halten (de, en, es, ja, tr, zh), um spätere Diffs zu minimieren.public/locales/tr.json (2)
611-618
: Language-menu values look good – verify order consistency with other localesStrings are translated and the
"tr": "Türkçe"
entry is present.
If other locale files keep the language list alphabetically (by code or name), replicate that order here to avoid diff churn later.
1-619
: Validate JSON syntax in CILarge manual JSON additions are error-prone (missing commas / quotes).
Consider adding a lint step (e.g.jq . public/locales/*.json
) to your pipeline to prevent deploy-time surprises.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
public/locales/de.json
(1 hunks)public/locales/en.json
(1 hunks)public/locales/es.json
(1 hunks)public/locales/ja.json
(1 hunks)public/locales/tr.json
(1 hunks)public/locales/zh.json
(1 hunks)
🔇 Additional comments (1)
public/locales/tr.json (1)
328-338
: Confirm that{{email}}
placeholder matches the source locale
authenticated_as: "Kimlik doğrulandı: {{email}}"
correctly keeps the{{email}}
token, but please double-check that the English (or base) locale uses the exact same token name. Mismatching token names silently break interpolation at runtime.
✅ Replaced all |
Tip For best results, initiate chat on the files or code changes. @mrcandev You're very welcome! 🎉 Great job on standardizing the placeholder syntax across all locale files for proper i18next compatibility. The Turkish language support addition is excellent, and fixing the placeholder consistency makes the internationalization much more robust. Thank you for this valuable contribution to the project! If you found this review helpful, would you consider giving us a shout-out on X? Thank you for using CodeRabbit! |
This PR is ready to be merged ✅ Let me know if anything else is needed 🙌 |
@mrcandev Thanks for your contribution! This PR will be merged and available in the next release 🎉 |
✅ Add Turkish Language Support
This PR adds full Turkish language support to the project:
tr.json
Thank you for your work on this great project.
Best regards,
Ömer Aydınoğlu 🇹🇷
Summary by CodeRabbit