Skip to content

Add Turkish Language Support #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add Turkish Language Support #699

wants to merge 2 commits into from

Conversation

mrcandev
Copy link

@mrcandev mrcandev commented Jul 20, 2025 •
edited by coderabbitai bot
Loading

✅ Add Turkish Language Support

This PR adds full Turkish language support to the project:

  • Added tr.json
  • Updated language menu in existing locale files

Thank you for your work on this great project.

Best regards,
Ömer Aydınoğlu 🇹🇷

Summary by CodeRabbit

  • New Features
    • Added full Turkish language support, enabling users to experience the entire application interface in Turkish.
    • Updated language menus across all supported languages to include Turkish as a selectable option.
  • Bug Fixes
    • Corrected error message templates in API key notifications for all languages to improve message formatting consistency.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 20, 2025 •
edited
Loading

Walkthrough

A new Turkish localization file has been added, providing full Turkish language support for the application's UI. Additionally, the Turkish language option ("tr") has been appended to the language selection menu in all existing locale files (English, German, Spanish, Japanese, and Chinese). The placeholder syntax for API key error messages was standardized from ${error} to {{error}} in these locale files.

Changes

Files Change Summary
public/locales/tr.json Added comprehensive Turkish localization file for the entire application UI.
public/locales/en.json, de.json, es.json, ja.json, zh.json Updated API key notification error message placeholders from ${error} to {{error}}; added Turkish language entry ("tr") to language menus.

Possibly related PRs

  • fix: Api Key is not displayed #452: Restructures API key notification messages in locale files, overlapping with changes to notification keys and message formats.
  • feat: better error messages #439: Expands and restructures error and success messages for API key notifications in localization files, related to the same keys modified here.

Suggested labels

Type: Enhancement

Poem

🐇
A new tongue now joins the crew,
Turkish words, fresh and new!
Menus gleam with choices bright,
Multilingual delight in sight.
From login screens to every view,
Rabbits cheer—"Hoş geldin" to you!
🌷

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e97eff1 and 7149116.

📒 Files selected for processing (6)
  • public/locales/de.json (2 hunks)
  • public/locales/en.json (2 hunks)
  • public/locales/es.json (2 hunks)
  • public/locales/ja.json (2 hunks)
  • public/locales/tr.json (1 hunks)
  • public/locales/zh.json (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • public/locales/ja.json
🚧 Files skipped from review as they are similar to previous changes (5)
  • public/locales/en.json
  • public/locales/de.json
  • public/locales/zh.json
  • public/locales/es.json
  • public/locales/tr.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jul 20, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (7)
public/locales/ja.json (1)

604-605: Turkish entry looks good – optional key ordering tweak

"tr": "トルコ語" is correct and the trailing comma on the "de" line keeps the JSON valid.
For consistency and smaller diffs down the road, consider sorting the language_menu keys alphabetically (e.g. de, en, es, ja, tr, zh) in every locale file.

public/locales/zh.json (1)

604-605: 新增土耳其语项 👍 – 可选: 统一按键名排序

"tr": "土耳其语" 译名准确，语法无误。
同样可酌情将 language_menu 的键按字母顺序统一，方便后续维护。

public/locales/es.json (1)

604-605: Entrada de “Turco” correcta – sugerencia menor de ordenación

La clave y la traducción son correctas.
Como detalle, ordenar alfabéticamente las claves del menú (de, en, es, ja, tr, zh) evitará futuros conflictos de merge.

public/locales/en.json (1)

616-617: “Turkish” added correctly – keep an eye on key order

Nothing functionally wrong here.
If you decide to alphabetise the keys, move "de"/"tr" to maintain a consistent sequence across locale files.

public/locales/de.json (1)

603-604: Eintrag „Türkisch“ passt – optionale Sortier-Optimierung

Übersetzung stimmt.
Kleine Pflege-Idee: die Schlüssel in language_menu überall alphabetisch halten (de, en, es, ja, tr, zh), um spätere Diffs zu minimieren.

public/locales/tr.json (2)

611-618: Language-menu values look good – verify order consistency with other locales

Strings are translated and the "tr": "Türkçe" entry is present.
If other locale files keep the language list alphabetically (by code or name), replicate that order here to avoid diff churn later.

1-619: Validate JSON syntax in CI

Large manual JSON additions are error-prone (missing commas / quotes).
Consider adding a lint step (e.g. jq . public/locales/*.json) to your pipeline to prevent deploy-time surprises.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d258204 and e97eff1.

📒 Files selected for processing (6)
  • public/locales/de.json (1 hunks)
  • public/locales/en.json (1 hunks)
  • public/locales/es.json (1 hunks)
  • public/locales/ja.json (1 hunks)
  • public/locales/tr.json (1 hunks)
  • public/locales/zh.json (1 hunks)
🔇 Additional comments (1)
public/locales/tr.json (1)

328-338: Confirm that {{email}} placeholder matches the source locale

authenticated_as: "Kimlik doğrulandı: {{email}}" correctly keeps the {{email}} token, but please double-check that the English (or base) locale uses the exact same token name. Mismatching token names silently break interpolation at runtime.

@mrcandev
Copy link
Author

✅ Replaced all ${error} placeholders with {{error}} for i18next compatibility across all locale files. Thanks again @coderabbitai!

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 20, 2025

Tip

For best results, initiate chat on the files or code changes.

@mrcandev You're very welcome! 🎉 Great job on standardizing the placeholder syntax across all locale files for proper i18next compatibility. The Turkish language support addition is excellent, and fixing the placeholder consistency makes the internationalization much more robust.

Thank you for this valuable contribution to the project!

If you found this review helpful, would you consider giving us a shout-out on X?

Thank you for using CodeRabbit!

@mrcandev
Copy link
Author

This PR is ready to be merged ✅ Let me know if anything else is needed 🙌

@amhsirak amhsirak added the Scope: i18n Translations All issues/PRs related to language translations label Jul 21, 2025
@amhsirak
Copy link
Member

@mrcandev Thanks for your contribution! This PR will be merged and available in the next release 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@amhsirak amhsirak amhsirak approved these changes

Assignees
No one assigned
Labels
Scope: i18n Translations All issues/PRs related to language translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrcandev @amhsirak