Skip to content

fix(maxun-core): run stuck in endless loop of clicking on pagination buttons #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(maxun-core): run stuck in endless loop of clicking on pagination buttons #876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions maxun-core/src/interpret.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1246,9 +1246,9 @@ export default class Interpreter extends EventEmitter {
if (checkLimit()) return allResults;

let loadMoreCounter = 0;
// let previousResultCount = allResults.length;
// let noNewItemsCounter = 0;
// const MAX_NO_NEW_ITEMS = 2;
let previousResultCount = allResults.length;
let noNewItemsCounter = 0;
const MAX_NO_NEW_ITEMS = 5;

while (true) {
if (this.isAborted) {
Expand Down Expand Up @@ -1332,21 +1332,21 @@ export default class Interpreter extends EventEmitter {

await scrapeCurrentPage();

// const currentResultCount = allResults.length;
// const newItemsAdded = currentResultCount > previousResultCount;
const currentResultCount = allResults.length;
const newItemsAdded = currentResultCount > previousResultCount;

// if (!newItemsAdded) {
// noNewItemsCounter++;
// debugLog(`No new items added after click (${noNewItemsCounter}/${MAX_NO_NEW_ITEMS})`);
if (!newItemsAdded) {
noNewItemsCounter++;
debugLog(`No new items added after click (${noNewItemsCounter}/${MAX_NO_NEW_ITEMS})`);

// if (noNewItemsCounter >= MAX_NO_NEW_ITEMS) {
// debugLog(`Stopping after ${MAX_NO_NEW_ITEMS} clicks with no new items`);
// return allResults;
// }
// } else {
// noNewItemsCounter = 0;
// previousResultCount = currentResultCount;
// }
if (noNewItemsCounter >= MAX_NO_NEW_ITEMS) {
debugLog(`Stopping after ${MAX_NO_NEW_ITEMS} clicks with no new items`);
return allResults;
}
} else {
noNewItemsCounter = 0;
previousResultCount = currentResultCount;
}

if (checkLimit()) return allResults;

Expand Down