Skip to content

odk-reporter: re-scope return var for clarity #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alxndrsn wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

odk-reporter: re-scope return var for clarity #1721

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/data/odk-reporter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@ const convertObjectToXml = (data) => {
// and are XML-encoded for safety. Object keys are assumed safe and not encoded,
// as they are generated by the application, not users.

let output = '';
if (typeof data === 'object') {
let output = '';

for (const k in data) {
if (Object.hasOwn(data, k)) {
if (Array.isArray(data[k])) {
Expand All @@ -40,10 +41,11 @@ const convertObjectToXml = (data) => {
}
}
}

return output;
} else {
return encodeXML(String(data));
}
return output;
};

const buildSubmission = (formId, formVersion, data) => {
Expand Down