Skip to content

Conversation

@alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Jan 30, 2026

Per suggestion at #1599 (comment)

What has been done to verify that this works as intended?

Updated tests.

Why is this the best possible solution? Were any other approaches considered?

Aims for exact support for the same keywords as github would support in a normal default-branch setup.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

No effect.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • branched off and targeted the next branch OR only changed documentation/infrastructure (master is stable and used in production)
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@alxndrsn alxndrsn changed the base branch from master to next January 30, 2026 09:59
@alxndrsn alxndrsn changed the title Close issues full keyword support ci/close-issues: support all official keywords Jan 30, 2026
@alxndrsn alxndrsn marked this pull request as ready for review January 30, 2026 10:06
@alxndrsn alxndrsn requested a review from latin-panda January 30, 2026 10:06
Copy link
Contributor

@latin-panda latin-panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

@alxndrsn alxndrsn merged commit b590cae into getodk:next Jan 30, 2026
5 checks passed
@alxndrsn alxndrsn deleted the close-issues-full-keyword-support branch January 30, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants