Extract components for rendering items on a map - #7220
Merged
Conversation
seadowg
force-pushed
the
reference-geometry
branch
from
May 13, 2026 09:56
640a59e to
b8c380c
Compare
seadowg
marked this pull request as ready for review
May 13, 2026 12:43
6 tasks
grzesiek2010
requested changes
May 19, 2026
seadowg
force-pushed
the
reference-geometry
branch
from
May 19, 2026 10:55
da89d0e to
3ae69b6
Compare
grzesiek2010
approved these changes
May 20, 2026
Member
Member
Author
|
@grzesiek2010 we can wait! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #7118
Blocked by #7165Why is this the best possible solution? Were any other approaches considered?
This extracts a new shared component (
MappableItemsDelegate) for rendering items (MappableItem) on a map along with test helpers for making assertions around this. This should support adding reference geometry to the geopoint/geopoly question UIs.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I think some brief testing of select one from map is fine here. The changes are all outside of the map implementations themselves so just testing with OSM is fine.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest