Skip to content

Extract components for rendering items on a map - #7220

Merged
grzesiek2010 merged 12 commits into
getodk:masterfrom
seadowg:reference-geometry
May 20, 2026
Merged

Extract components for rendering items on a map#7220
grzesiek2010 merged 12 commits into
getodk:masterfrom
seadowg:reference-geometry

Conversation

@seadowg

@seadowg seadowg commented May 6, 2026

Copy link
Copy Markdown
Member

Work towards #7118
Blocked by #7165

Why is this the best possible solution? Were any other approaches considered?

This extracts a new shared component (MappableItemsDelegate) for rendering items (MappableItem) on a map along with test helpers for making assertions around this. This should support adding reference geometry to the geopoint/geopoly question UIs.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

I think some brief testing of select one from map is fine here. The changes are all outside of the map implementations themselves so just testing with OSM is fine.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg added the blocked label May 7, 2026
@seadowg
seadowg force-pushed the reference-geometry branch from 640a59e to b8c380c Compare May 13, 2026 09:56
@seadowg seadowg removed the blocked label May 13, 2026
@seadowg
seadowg marked this pull request as ready for review May 13, 2026 12:43
@seadowg
seadowg requested a review from grzesiek2010 May 13, 2026 12:44
Comment thread geo/src/test/java/org/odk/collect/geo/support/MapFragmentAssertions.kt Outdated
Comment thread geo/src/test/java/org/odk/collect/geo/support/MapFragmentAssertions.kt Outdated
Comment thread geo/src/main/java/org/odk/collect/geo/items/MappableItemsDelegate.kt Outdated
Comment thread geo/src/main/java/org/odk/collect/geo/items/MappableItemsDelegate.kt Outdated
Comment thread geo/src/main/java/org/odk/collect/geo/items/MappableItemsDelegate.kt Outdated
@seadowg
seadowg force-pushed the reference-geometry branch from da89d0e to 3ae69b6 Compare May 19, 2026 10:55
@seadowg
seadowg requested a review from grzesiek2010 May 19, 2026 11:58
@grzesiek2010
grzesiek2010 merged commit 8118e87 into getodk:master May 20, 2026
8 checks passed
@grzesiek2010

Copy link
Copy Markdown
Member

@seadowg do you want this PR to be tested or wait for #7235 and test everything together?

@seadowg

seadowg commented May 20, 2026

Copy link
Copy Markdown
Member Author

@grzesiek2010 we can wait!

@seadowg
seadowg deleted the reference-geometry branch May 20, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants