Spaces after CSV delimiters are not stripped#811
Open
lognaturel wants to merge 1 commit intogetodk:masterfrom
Open
Spaces after CSV delimiters are not stripped#811lognaturel wants to merge 1 commit intogetodk:masterfrom
lognaturel wants to merge 1 commit intogetodk:masterfrom
Conversation
lognaturel
force-pushed
the
csv-tests
branch
from
1e9cc9a to
4a9ae5b
Compare
seadowg
requested changes
Dec 17, 2024
Member
seadowg
left a comment
seadowg
left a comment
There was a problem hiding this comment.
Definitely good to add these tests! How would you feel about reworking them slightly so that each test writes (and then parses) its own CSV file? It's easy enough to track with the diff here, but it's awkward to reason about the test with it not being clear why individual child nodes are being picked out without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests illustrating that spaces after CSV delimiters are not stripped. This is something users sometimes run into when they build CSVs by hand. To make matters more confusing, Enketo does strip whitespace so issues are only caught when testing with Collect.
For now I want to make sure we have tests so that the behavior is documented and can't change without being noticed.
I followed the test style in that suite.