fix(linters): upgrade buf to 1.60.0 #984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malept
requested changes
Sep 24, 2025
Member
malept
left a comment
malept
left a comment
There was a problem hiding this comment.
I already discussed this with Andrew, but this needs an ecosystem regression test before we can approve.
Contributor
|
Link to code coverage report (posted by coverbot 🤖) |
Contributor
Author
Only failures as of posting are repo not found{"level":"error","repo":"msftspeechapi","dir":"/tmp/crucible-test-1777529767/msftspeechapi","url":"[email protected]:getoutreach/msftspeechapi","error":"repository not found","time":"2025-10-13T09:57:38Z","message":"FAILED TO CLONE REPO"}{"level":"error","repo":"ds-cds-golang-forecast-service","dir":"/tmp/crucible-test-2532380528/ds-cds-golang-forecast-service","url":"[email protected]:getoutreach/ds-cds-golang-forecast-service","error":"repository not found","time":"2025-10-13T09:57:20Z","message":"FAILED TO CLONE REPO"} |
AndrewWinterman
force-pushed
the
fix-buf-version
branch
from
bdd7afd to
e93b019
Compare
malept
changed the title
malept
approved these changes
Nov 26, 2025
| gojq: v0.12.17 | ||
|
|
||
| # protobuf formatters/plugins/tools/etc | ||
| buf: 1.8.0 # formatter |
Member
There was a problem hiding this comment.
Deleted the comment because it will be more than a formatter starting with #1009
|
🎉 This PR is included in version 2.34.6-rc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read CONTRIBUTING.md for additional information on contributing to this repository!
What this PR does / why we need it
I'd like to test out buf in a new service (tombstone), but the existing version of buf is so old it doesn't support the version2 configuration files.
This PR upgrades the buf version.
I am still testing this out, but I think it should be safe since buf still supports v1 yaml schemas.
Jira ID
[XX-XX]
Notes for your reviewers