Publish Examples with Latest Tag #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…publish with latest tag. Updated command to publish example bundle with an additional step for tagging. Signed-off-by: Kim Christensen <[email protected]>
kichristensen
force-pushed
the
pushLatestTag
branch
from
8cf397a to
5a9a587
Compare
…roved consistency in mixin installations. Signed-off-by: Kim Christensen <[email protected]>
… improve reliability of mixin installations. Signed-off-by: Kim Christensen <[email protected]>
dgannon991
reviewed
Jul 24, 2025
| return porter.EnsureMixin(mixin) | ||
| }) | ||
| } | ||
| return errG.Wait() | ||
| } | ||
|
|
||
| func EnsurePorter() { | ||
| porter.EnsurePorter() | ||
| porter.EnsurePorterAt("v1.2.1") |
There was a problem hiding this comment.
Is it worth updating the DefaultPorterVersion variable instead?
There was a problem hiding this comment.
@dgannon991 Yes we probably should, but it requires the magefiles repository to be updated. I will create a PR for that, but I think it make sense to do it here for now to unblock.
There was a problem hiding this comment.
@kichristensen Sorry, I know it's my fault, but is it worth changing this to 1.3.0?
There was a problem hiding this comment.
@dgannon991 Good point :) I have just merged the update to magefiles, with should change the default version to 1.3.0, so this can be removed again, I will do that once the magefiles release have been created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
PublishExamplefunction to publish example bundles with both version-specific and latest tagscloses getporter/porter#3020
Why
This change ensures that example bundles are available with both version-specific tags and a
latesttag, making it easier for users to reference the most recent version of examples while maintaining version history.Impact
This change improves the usability of example bundles by providing a consistent way to reference the latest version while maintaining version history.