-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Advanced query search syntax for multi byte search #7546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yoshiokatsuneo
merged 5 commits into
getredash:master
from
yoshiokatsuneo:feat/advanced_query_search_syntax_for_multi_byte_search
Oct 15, 2025
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9e23b1e
Advanced query search syntax for multi byte search
yoshiokatsuneo e0cee56
Advanced search for my queries
yoshiokatsuneo 43148ba
Add advanced query seearch tooltip
yoshiokatsuneo 2ee9501
Revert "Add advanced query seearch tooltip"
yoshiokatsuneo 71a79ea
Merge branch 'master' into feat/advanced_query_search_syntax_for_mult…
yoshiokatsuneo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a better way to break words and "multiple words" into tokens? This regex appears to work, may also contain hard-to-find edge cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eradman
Thank you for the review!
At first, the query string matches one of those.
And, the keyword matches one of those:
I think this covers the all 4 cases( 2 cases x 2 cases).
Or, we may implement simple tokenizer. That makes more flexible, but it need a bit of code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regex is very compact. We can refactor this in the future if we need more flexibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eradman
I see. Thank you !