Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Nov 20, 2025

Adds Scope's attributes to Sentry Log messages

Follow up to #6830

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 2854019

@itaybre itaybre marked this pull request as ready for review November 20, 2025 10:35
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.868%. Comparing base (6566e2d) to head (2854019).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@                          Coverage Diff                          @@
##           itay/scopes_set_attributes_logs     #6834       +/-   ##
=====================================================================
- Coverage                           84.869%   84.868%   -0.002%     
=====================================================================
  Files                                  452       453        +1     
  Lines                                27613     27624       +11     
  Branches                             12104     12108        +4     
=====================================================================
+ Hits                                 23435     23444        +9     
+ Misses                                4135      3892      -243     
- Partials                                43       288      +245     
Files with missing lines Coverage Δ
Sources/Swift/Tools/SentryLogBatcher.swift 98.518% <100.000%> (+0.056%) ⬆️

... and 50 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6566e2d...2854019. Read the comment docs.

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Nov 20, 2025
@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1205.08 ms 1232.14 ms 27.06 ms
Size 24.15 KiB 1.02 MiB 1016.13 KiB

Baseline results on branch: itay/scopes_set_attributes_logs

Startup times

Revision Plain With Sentry Diff
4f7825f 1229.96 ms 1266.36 ms 36.40 ms

App size

Revision Plain With Sentry Diff
4f7825f 24.15 KiB 1.01 MiB 1015.11 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants