docs(sentry-dio): improve addSentry method documentation#2912
Merged
buenaflor merged 2 commits intogetsentry:mainfrom May 7, 2025
Merged
docs(sentry-dio): improve addSentry method documentation#2912buenaflor merged 2 commits intogetsentry:mainfrom
addSentry method documentation#2912buenaflor merged 2 commits intogetsentry:mainfrom
Conversation
buenaflor
approved these changes
May 6, 2025
Contributor
buenaflor
left a comment
There was a problem hiding this comment.
Thanks!
Do you mind also fixing the sentry docs for this? This is important info and isn't mentioned there.
Otherwise I can take care of that :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2912 +/- ##
==========================================
+ Coverage 87.63% 96.93% +9.30%
==========================================
Files 272 9 -263
Lines 9047 163 -8884
==========================================
- Hits 7928 158 -7770
+ Misses 1119 5 -1114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tsinis
added a commit
to tsinis/sentry-docs
that referenced
this pull request
May 6, 2025
6 tasks
Contributor
Author
Hi @buenaflor, sure, here is sentry-docs counterpart. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Improves the
addSentry()method documentation in thesentry_diopackage with clearer usage examples and explanation.The updated docs now clearly explain that Sentry should be added as the last step in Dio configuration, ensuring that it uses the user's custom configuration rather than overriding it. Kudos to @ueman.
💡 Motivation and Context
When integrating Sentry with Dio, users need to understand the correct order of operations. Previously, the documentation didn't fully clarify that
addSentry()should be called last after any custom transformer or adapter configuration. This led to confusion when users wanted to use custom Dio components alongside Sentry.This documentation improvement addresses the "Next steps" item from the previous PR that exported
SentryTransformer, by explaining howaddSentry()works with custom configurations.💚 How did you test it?
addSentry()functions.📝 Checklist
sendDefaultPiiis enabled#skip-changelog