fix(nextjs): Return correct lastEventId for SSR pages#19232
Closed
fix(nextjs): Return correct lastEventId for SSR pages#19232
lastEventId for SSR pages#19232Conversation
Contributor
Codecov Results 📊Generated by Codecov Action |
Member
|
As discussed offline: I think this is already happening by the underlying Let's test this in an integration test and see if it's causing an issue there, and maybe we even have to try an ssr e2e test. |
Member
Author
|
Closing this, as this is probably not the core issue. See this comment: #19217 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where
Sentry.lastEventId()would returnundefinedafter callingcaptureUnderscoreErrorException()in Next.js error pages. In Next.js SSR, each incoming request gets its own isolation scope (forked automatically).The function now explicitly sets the event ID on the isolation scope, making it accessible via
lastEventId()for displaying error reference IDs to users on custom error pages. Includes a test to verify the fix (test breaks without setting the ID on the isolation scope).Closes #19217