Skip to content

Commit a217fbd

Browse files
nsdeschenesnatemoo-regetsantry[bot]
authored
chore(ui): Add comment for new theme spaces (#96003)
This PR adds in JSDoc comments for the new spaces values in the theme, this makes it a bit easier to reference when using them, as I found myself going back to a slack post to figure out which sizes lined up with the previous space values. --------- Co-authored-by: Nate Moore <[email protected]> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com> Co-authored-by: Nate Moore <[email protected]>
1 parent 6210cba commit a217fbd

File tree

1 file changed

+24
-0
lines changed

1 file changed

+24
-0
lines changed

static/app/utils/theme/theme.tsx

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1092,13 +1092,37 @@ const iconSizes: Record<Size, string> = {
10921092

10931093
const space = {
10941094
none: '0px',
1095+
/**
1096+
* Equivalent to deprecated `space(0.25)`
1097+
*/
10951098
'2xs': '2px',
1099+
/**
1100+
* Equivalent to deprecated `space(0.5)`
1101+
*/
10961102
xs: '4px',
1103+
/**
1104+
* Equivalent to deprecated `space(0.75)`
1105+
*/
10971106
sm: '6px',
1107+
/**
1108+
* Equivalent to deprecated `space(1)`
1109+
*/
10981110
md: '8px',
1111+
/**
1112+
* Equivalent to deprecated `space(1.5)`
1113+
*/
10991114
lg: '12px',
1115+
/**
1116+
* Equivalent to deprecated `space(2)`
1117+
*/
11001118
xl: '16px',
1119+
/**
1120+
* Equivalent to deprecated `space(3)` (was `20px`)
1121+
*/
11011122
'2xl': '24px',
1123+
/**
1124+
* Equivalent to deprecated `space(4)` (was `30px`)
1125+
*/
11021126
'3xl': '32px',
11031127
} as const;
11041128

0 commit comments

Comments
 (0)