-
-
Couldn't load subscription status.
- Fork 4.5k
feat(workflow_engine): Add Detector Life Cycle Hooks to DetectorSettings #101964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #101964 +/- ##
=========================================
Coverage 80.96% 80.97%
=========================================
Files 8721 8729 +8
Lines 387850 388533 +683
Branches 24554 24554
=========================================
+ Hits 314034 314602 +568
- Misses 73468 73583 +115
Partials 348 348 |
…turn value, otherwise it'll throw)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM to me, but I'll let Evan approve since I'm not the most familiar with hooks.
Description
hooksI'm not quite sure where the best place to add the status change for
on_enable/on_disable, but wanted to get the core of the updates in. That will be addressed in a separate PR.