Skip to content

Conversation

@saponifi3d
Copy link
Contributor

@saponifi3d saponifi3d commented Oct 22, 2025

Description

  • Updates the DetectorSettings to have an optional hooks
  • Create optional hooks for:
    • on_create
    • on_update
    • on_delete
  • Invokes hooks during the detectors life cycle events.

I'm not quite sure where the best place to add the status change for on_enable / on_disable, but wanted to get the core of the updates in. That will be addressed in a separate PR.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #101964    +/-   ##
=========================================
  Coverage   80.96%    80.97%            
=========================================
  Files        8721      8729     +8     
  Lines      387850    388533   +683     
  Branches    24554     24554            
=========================================
+ Hits       314034    314602   +568     
- Misses      73468     73583   +115     
  Partials      348       348            

@saponifi3d saponifi3d marked this pull request as ready for review October 24, 2025 23:03
@saponifi3d saponifi3d requested review from a team as code owners October 24, 2025 23:03
Copy link
Contributor

@mifu67 mifu67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM to me, but I'll let Evan approve since I'm not the most familiar with hooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants